Adding support for macro expansion request #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@JakeBecker Hey, with this PR I'm adding support for macro expansions. I've got it working through my fork of alchemist.el in emacs. What's needed to get this mergeable? |
Trevoke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm trying to make this the back-end for alchemist.el ( tonini/alchemist.el#341 ) and one of the features I'm trying to use is macro expansion. It looks like elixir_sense, your back-end, supports this, so I intend to add support for it in elixir-ls as well.
Unfortunately I'm not entirely certain of how you want this to look, nor am I entirely certain of exactly what data I'm supposed to get from emacs all the way to elixir_sense -- so I figured, I might be able to get an early review / guidance from you.
I aded a macro in the protocol file, and I used it in the server file... And that's when things went slightly awry. Anyway - how does this look so far?
This is probably beyond your purview, but for the sake of completeness, I'm using
ElixirSense.expand_full/3https://github.com/msaraiva/elixir_sense/blob/master/lib/elixir_sense.ex#L264 and I've already got an issue open on the elixir_sense repo asking what the variables mean: msaraiva/elixir_sense#27 .